x/pkgsite: delete from module from version_map in postgres.DeleteModule #39633
Labels
Milestone
Comments
@julieqiu can I work on this? I am new to this repo. I am planning to the same approach as in https://github.com/golang/pkgsite/blob/df627db60a835a59120b45fe7af59779840aa522/internal/postgres/insert_module_test.go#L307 but with "version_map" table. Is my approach correct? |
For sure! Thanks @bharaththiruveedula - here's the relevant info for this: At the moment, when we call postgres.DeleteModule we will delete from the following tables:
We also want to delete from the version_map table. The task here would be to add that to postgres.DeleteModule, and also add a test. |
Thanks for giving the context. I will work on this @julieqiu |
@julieqiu pushed the changes to https://go-review.googlesource.com/c/pkgsite/+/238637. Can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See:
https://github.com/golang/pkgsite/blob/df627db60a835a59120b45fe7af59779840aa522/internal/postgres/insert_module_test.go#L312
Related: #39621
The text was updated successfully, but these errors were encountered: