archive/zip: data race

[dvyukov]

ThreadSanitizer says:

WARNING: DATA RACE
Write by goroutine 24:
  archive/zip.readDataDescriptor()
      src/pkg/archive/zip/reader.go:267 +0x2be
  archive/zip.(*checksumReader).Read()
      src/pkg/archive/zip/reader.go:164 +0x294
  bytes.(*Buffer).ReadFrom()
      src/pkg/bytes/buffer.go:166 +0x3cc
  io.Copy()
      src/pkg/io/io.go:352 +0xc6
  archive/zip.readTestFile()
      src/pkg/archive/zip/reader_test.go:329 +0x7ad
  archive/zip.func·001()
      src/pkg/archive/zip/reader_test.go:287 +0x16d

Previous read by goroutine 27:
  archive/zip.(*File).Open()
      src/pkg/archive/zip/reader.go:126 +0xbf
  archive/zip.readTestFile()
      src/pkg/archive/zip/reader_test.go:319 +0x4ca
  archive/zip.func·001()
      src/pkg/archive/zip/reader_test.go:287 +0x16d

Goroutine 24 (running) created at:
  archive/zip.readTestZip()
      src/pkg/archive/zip/reader_test.go:289 +0x834
  archive/zip.TestReader()
      src/pkg/archive/zip/reader_test.go:236 +0xe7
  testing.tRunner()
      src/pkg/testing/testing.go:297 +0xc9

Goroutine 27 (running) created at:
  archive/zip.readTestZip()
      src/pkg/archive/zip/reader_test.go:289 +0x834
  archive/zip.TestReader()
      src/pkg/archive/zip/reader_test.go:236 +0xe7
  testing.tRunner()
      src/pkg/testing/testing.go:297 +0xc9

[robpike]

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 2:

What version of the code do you have? I can't make sense of the line numbers.

[rsc]

Comment 3:

Labels changed: added go1.1maybe.

[dvyukov]

Comment 5:

Accidentally fixed by https://golang.org/cl/6463050
readDataDescriptor() does not overwrite CompressedSize/UncompressedSize any more.

Status changed to Fixed.