Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: s390x floating point <-> integer conversions clobbering the condition code [1.13 backport] #39689

Closed
gopherbot opened this issue Jun 18, 2020 · 3 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 18, 2020

@mundaym requested issue #39651 to be considered for backport to the next 1.13 minor release.

@gopherbot please consider this for a backport

This is a bug that affects the control flow of a program running on s390x and therefore can result in it behaving incorrectly. The fix is simple and safe and only affects s390x.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 10, 2020

Approved for 1.14 (#39690) and 1.13 (this issue) as it's a serious problem without a workaround.

@dmitshur dmitshur added CherryPickApproved and removed CherryPickCandidate labels Jul 10, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 13, 2020

Change https://golang.org/cl/242238 mentions this issue: [release-branch.go1.13] cmd/compile: mark s390x int <-> float conversions as clobbering flags

@andybons andybons removed this from the Go1.13.13 milestone Jul 14, 2020
@andybons andybons added this to the Go1.13.14 milestone Jul 14, 2020
@andybons andybons removed this from the Go1.13.14 milestone Jul 16, 2020
@andybons andybons added this to the Go1.13.15 milestone Jul 16, 2020
@toothrot toothrot removed this from the Go1.13.15 milestone Aug 6, 2020
@toothrot toothrot added this to the Go1.13.16 milestone Aug 6, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Aug 21, 2020

Go 1.13 is no longer supported per release policy, so this backport issue is no longer needed and can be closed.

@golang golang locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

4 participants