Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: s390x floating point <-> integer conversions clobbering the condition code [1.14 backport] #39690

Closed
gopherbot opened this issue Jun 18, 2020 · 6 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 18, 2020

@mundaym requested issue #39651 to be considered for backport to the next 1.14 minor release.

@gopherbot please consider this for a backport

This is a bug that affects the control flow of a program running on s390x and therefore can result in it behaving incorrectly. The fix is simple and safe and only affects s390x.

@gopherbot gopherbot added the CherryPickCandidate label Jun 18, 2020
@gopherbot gopherbot added this to the Go1.14.5 milestone Jun 18, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 10, 2020

Approved for 1.14 (this issue) and 1.13 (#39689) as it's a serious problem without a workaround.

@dmitshur dmitshur added CherryPickApproved and removed CherryPickCandidate labels Jul 10, 2020
@gopherbot

This comment has been minimized.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 10, 2020

@mundaym This backport doesn't apply cleanly. Would you like to work on creating the backport CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls and see if the merge conflict can be resolved in a safe way? Thanks.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 13, 2020

Change https://golang.org/cl/242237 mentions this issue: [release-branch.go1.14] cmd/compile: mark s390x int <-> float conversions as clobbering flags

@mundaym
Copy link
Member

@mundaym mundaym commented Jul 13, 2020

Thanks @dmitshur. I've done the backports and they are both safe.

@andybons andybons removed this from the Go1.14.5 milestone Jul 14, 2020
@andybons andybons added this to the Go1.14.6 milestone Jul 14, 2020
@andybons andybons removed this from the Go1.14.6 milestone Jul 16, 2020
@andybons andybons added this to the Go1.14.7 milestone Jul 16, 2020
@toothrot toothrot removed this from the Go1.14.7 milestone Aug 6, 2020
@toothrot toothrot added this to the Go1.14.8 milestone Aug 6, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Aug 21, 2020

Closed by merging db4890e to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Aug 21, 2020
…ions as clobbering flags

These conversion instructions set the condition code and so should
be marked as clobbering flags.

Updates #39651.
Fixes #39690.

Change-Id: I1e3f2cf33337128d321b52ac72f46d1b8798ebd9
Reviewed-on: https://go-review.googlesource.com/c/go/+/242237
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@dmitshur dmitshur removed this from the Go1.14.8 milestone Sep 1, 2020
@dmitshur dmitshur added this to the Go1.14.9 milestone Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

5 participants