Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/present: Markdown code blocks are formatted without background color #39730

Closed
autarch opened this issue Jun 20, 2020 · 3 comments
Closed

Comments

@autarch
Copy link

@autarch autarch commented Jun 20, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.2 linux/amd64

Does this issue reproduce with the latest release?

This isn't an issue with the go core.

I did install the latest version of present with go get -u golang.org/x/tools/cmd/present

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/autarch/.cache/go-build"
GOENV="/home/autarch/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="github.com/ActiveState"
GONOSUMDB="github.com/ActiveState"
GOOS="linux"
GOPATH="/home/autarch/go"
GOPRIVATE="github.com/ActiveState"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build349158934=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I converted my slides to Markdown formatting.

What did you expect to see?

With the legacy syntax, a code block (indented by 4 spaces or a tab) would be formatted with a grey background and a border around the entire block.

What did you see instead?

With the Markdown syntax, there is no background or border.

@gopherbot gopherbot added the Tools label Jun 20, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2020
@robpike
Copy link
Contributor

@robpike robpike commented Jun 20, 2020

This is intentional. The presentation design, however it is formatted, is minimalist, and Markdown only specifies fonts, bullets and so on, not tonality.

To put it another way, they weren't colored before the change, and they are still not colored.

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 24, 2020

The issue has been responded to. Adding the tools team for visibility:

/cc @golang/tools-team

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 24, 2020

Sounds like we can probably close this.

@stamblerre stamblerre closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.