Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: omit empty JSON-RPC error data #39736

Closed
uhthomas opened this issue Jun 21, 2020 · 2 comments
Closed

x/tools/gopls: omit empty JSON-RPC error data #39736

uhthomas opened this issue Jun 21, 2020 · 2 comments
Labels
Milestone

Comments

@uhthomas
Copy link

@uhthomas uhthomas commented Jun 21, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.4 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/thomas/Library/Caches/go-build"
GOENV="/Users/thomas/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY="code.cfops.it"
GONOSUMDB="code.cfops.it"
GOOS="darwin"
GOPATH="/Users/thomas/go"
GOPRIVATE="code.cfops.it"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/thomas/cloudflare/segments/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/d5/hqd0d3f17h7gmntg94k251z80000gn/T/go-build278475873=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

JSON-RPC errors always encode data as null. The spec states it may be omitted.

What did you expect to see?

JSON-RPC errors should not encode data if empty.

{
	"code": 0,
	"message": ""
}

What did you see instead?

{
	"code": 0,
	"message": "",
	"data": null
}
@gopherbot gopherbot added the Tools label Jun 21, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 21, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Jun 21, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 21, 2020

Change https://golang.org/cl/239059 mentions this issue: internal/jsonrpc2: Omit empty error data

@stamblerre stamblerre changed the title x/tools/gopls: Omit empty JSON-RPC error data x/tools/gopls: omit empty JSON-RPC error data Jun 24, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Jun 24, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.