Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: test pathNotFoundErrorNew #39759

Closed
jba opened this issue Jun 22, 2020 · 4 comments
Closed

x/pkgsite: test pathNotFoundErrorNew #39759

jba opened this issue Jun 22, 2020 · 4 comments

Comments

@jba
Copy link
Contributor

@jba jba commented Jun 22, 2020

Add a test that checks pathNotFoundErrorNew in internal/frontend/details.go.

@jba jba added the pkgsite label Jun 22, 2020
@jba jba self-assigned this Jun 22, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 22, 2020
@julieqiu julieqiu changed the title x/pkgsite: text pathNotFoundErrorNew x/pkgsite: test pathNotFoundErrorNew Jun 23, 2020
@AndersonQ
Copy link
Contributor

@AndersonQ AndersonQ commented Jun 30, 2020

I can help with this issue :)
However I have a question, the idea is to test the function pathNotFoundErrorNew or the ones using pathNotFoundErrorNew?

@julieqiu julieqiu unassigned jba Jul 1, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 1, 2020

Thanks, @AndersonQ! This issue is about testing function using pathNotFoundErrorNew. It is related to this:
https://github.com/golang/pkgsite/blob/master/internal/frontend/server_test.go#L832

@AndersonQ
Copy link
Contributor

@AndersonQ AndersonQ commented Jul 2, 2020

Thanks! Looking into it :)

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 5, 2020

Change https://golang.org/cl/241020 mentions this issue: internal/frontend: add test to frontend/server for ActiveFrontendFetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants