Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: EJI banner obscures widgets on page #39767

Closed
kortschak opened this issue Jun 23, 2020 · 7 comments
Closed

x/pkgsite: EJI banner obscures widgets on page #39767

kortschak opened this issue Jun 23, 2020 · 7 comments

Comments

@kortschak
Copy link
Contributor

@kortschak kortschak commented Jun 23, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

Screenshot

Screenshot from 2020-06-23 10-22-48

Note the sliver of a button being obscured by the banner.

What did you do?

Browse to page.

What did you expect to see?

No obstructed page widgets; page moved down to make room for banner.

What did you see instead?

Image above.

@gopherbot gopherbot added this to the Unreleased milestone Jun 23, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Jun 23, 2020

No, that's actually how the website looks. On mouseover, a little line appears on the top of the bar item.

Here's a screenshot without any banner:

cap

I'm closing here since it's working as intended. Feel free to comment if you think I'm wrong.

@ALTree ALTree closed this Jun 23, 2020
@kortschak
Copy link
Contributor Author

@kortschak kortschak commented Jun 23, 2020

It seems you're right. Why is that distracting pale blue bar there then? It's just noticeable enough to look wrong.

@ALTree
Copy link
Member

@ALTree ALTree commented Jun 23, 2020

Why is that distracting pale blue bar there then?

Not a web designer but I think is to mark the element your mouse is hovering. I agree it's a puzzling design choice, usually you do that by underling the words or by shading the whole button area with a different colour. I've never seen it done with a thin coloured line appearing on the top of the button.

EDIT: I'm wrong, the red one is to highlight, the blue one in the screenshot is a different thing.

@kortschak
Copy link
Contributor Author

@kortschak kortschak commented Jun 23, 2020

The issue is that the blue bar is always there (only above "Discover Packages") and looks like an obstructed widget; I can understand the red bar that shows up with hover. Also, not a web designer, but did grow up in a graphic design family. This is very odd design.

@ALTree ALTree reopened this Jun 23, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Jun 23, 2020

EDIT: actually I see it, on the "discover packages" item only. I think it's there to highlight it, and it's by design. Sorry for the confusion, but I think this is working as intended (and it's not changed by the banner, it's always like that).

@ALTree ALTree closed this Jun 23, 2020
@kortschak
Copy link
Contributor Author

@kortschak kortschak commented Jun 23, 2020

OK. I think it's bad design and probably should be changed; it's distracting and too subtle to actually draw attention to what it might be trying to draw attention to. This issue is not correct for that though and it seems like there's probably little interest in fixing it. If it will be entertained, I'll file an issue, otherwise I will just try to ignore it or continue to use godoc.org.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 23, 2020

@kortschak - feel free to file an issue. We can address this with our UX team for the next round of design changes.

/cc @fflewddur @Joanne881107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants