Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: add support for creating proxied TLS connections #39794

Open
elagergren-spideroak opened this issue Jun 23, 2020 · 1 comment
Open

net/http: add support for creating proxied TLS connections #39794

elagergren-spideroak opened this issue Jun 23, 2020 · 1 comment

Comments

@elagergren-spideroak
Copy link

@elagergren-spideroak elagergren-spideroak commented Jun 23, 2020

DialTLSContext is documented as only being used for non-proxied requests.

This is problematic because it means HTTPS CONNECT requests always use crypto/tls. This can violate business requirements and so on. (And can also lead to difficult to debug errors if you, uh, forget that DialTLSContext is only for non-proxied requests. Or if the proxy is added later.)

Ideally, Transport would have a Client(net.Conn, ...) net.Conn field that, if nil, would default to crypto/tls.

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.