Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/invoke/gocommand: tests are timing out #39802

Open
stamblerre opened this issue Jun 24, 2020 · 3 comments
Open

x/tools/internal/invoke/gocommand: tests are timing out #39802

stamblerre opened this issue Jun 24, 2020 · 3 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 24, 2020

Seems like a lot of tests are timing out on the builders (example failure). From the logs, my guess is that a serial go command invocation isn't returning in a reasonable amount of time, and it is blocking all the other go commands from running. A possible solution (or at least a first step for debugging) would be putting a timeout on a go command invocation.

/cc @heschik

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Jun 24, 2020
@gopherbot gopherbot added the Tools label Jun 24, 2020
@stamblerre stamblerre changed the title x/tools/invoke/gocommand: tests are timing out x/tools/internal/invoke/gocommand: tests are timing out Jun 24, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 24, 2020
@heschik
Copy link
Contributor

@heschik heschik commented Jun 24, 2020

That log also includes a timeout from the gcimporter test, so I'm skeptical it's specific to gocommand. I'm suspicious of an issue with the Darwin builders. But adding a timeout certainly wouldn't hurt.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jun 24, 2020

Here's a log from a go/packages test: https://build.golang.org/log/ef9541b14411917139a452379e0f4d641dcd5540.
And an imports one: https://build.golang.org/log/ef9541b14411917139a452379e0f4d641dcd5540.

Definitely specific to Darwin though, I can't find a similar failure on other builders.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jun 24, 2020

/cc @dmitshur @cagedmantis @toothrot

This seems like an issue specific to the Darwin builder, so we were wondering if we could get your help investigating. I can't find any cases of it happening on any other builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.