Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go2goplay: use a distinctive UI from play.golang.org #39809

Open
dolmen opened this issue Jun 24, 2020 · 2 comments
Open

go2goplay: use a distinctive UI from play.golang.org #39809

dolmen opened this issue Jun 24, 2020 · 2 comments

Comments

@dolmen
Copy link

@dolmen dolmen commented Jun 24, 2020

What version of Go are you using (go version)?

https://go2goplay.golang.org/

Does this issue reproduce with the latest release?

yes

What did you expect to see?

A clear marker that this is not a stable release of Go and that languages features are experimental.

This is important when a block of go2go code is shared on social media so that readers would not be confused thinking that the language features used are available in the production version currently available. The About page is not enough.

What did you see instead?

Exactly the same layout as https://play.golang.org/

Only the about page mention a different commit than play.golang.org.

Fix

Here are some ideas:

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 25, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2020

Change https://golang.org/cl/240541 mentions this issue: all: go2goplay.golang.org source

gopherbot pushed a commit to golang/playground that referenced this issue Jun 30, 2020
This CL contains the altered playground source that is served
at go2goplay.golang.org.

It compiles the toolchain at the dev.go2go branch of the main
Go repository, translates .go2 programs using the go2go tool,
and compiles the playground frontend binary using the dev.go2go
toolchain (to support code formatting).

The header and “About” text is updated to differentiate from
the normal playground and explain its differences,
code location, etc.

Most features present on play.golang.org are missing, and this
instance only supports single-file, non-test, main-package
programs. This was done for initial simplicity of the
implementation.

Updates golang/go#39675
Fixes golang/go#39809

Change-Id: Id9461830c4233ab3f938dc6d21da3e5f2d8adbc3
Reviewed-on: https://go-review.googlesource.com/c/playground/+/240541
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.