Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add metrics to teeproxy #39843

Closed
shaqque opened this issue Jun 25, 2020 · 2 comments
Closed

x/pkgsite: add metrics to teeproxy #39843

shaqque opened this issue Jun 25, 2020 · 2 comments
Assignees
@shaqque
Labels
NeedsFix pkgsite
Milestone
pkgsite/godoc.org...

Comments

@shaqque
Copy link
Contributor

@shaqque shaqque commented Jun 25, 2020

Add metrics to the teeproxy to measure latency and counts by response type.
@shaqque shaqque added NeedsFix pkgsite labels Jun 25, 2020
@shaqque shaqque self-assigned this Jun 25, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 25, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 25, 2020

Change https://golang.org/cl/239818 mentions this issue: internal/teeproxy: add metrics for requests
@gopherbot gopherbot closed this in golang/pkgsite@b027aae Jul 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 9, 2020

Change https://golang.org/cl/241600 mentions this issue: internal/teeproxy: fix pkgGoDevLatency use in recordTeeProxyMetric
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 9, 2020
@julieqiu
internal/teeproxy: fix pkgGoDevLatency use in recordTeeProxyMetric
a59b4ce 
recordTeeProxyMetric was using gddoLatency to calculate latency
for pkg.go.dev, which is now fixed.

For golang/go#39843

Change-Id: Id826d626b7409d75cf650df6b2191200f9a9dbe4
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/241600
Reviewed-by: Shaquille Que <shaquille@golang.org>
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/godoc.org-redirect Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaqque shaqque

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/godoc.org-redirect
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@julieqiu @gopherbot @shaqque