Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compile error when using sync.Pool: mismatched zero/store sizes [1.13 backport] #39848

Closed
gopherbot opened this issue Jun 25, 2020 · 3 comments
Closed

cmd/compile: internal compile error when using sync.Pool: mismatched zero/store sizes [1.13 backport] #39848

gopherbot opened this issue Jun 25, 2020 · 3 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.13.14

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 25, 2020

@randall77 requested issue #39459 to be considered for backport to the next 1.13 minor release.

@gopherbot please open backport issues for 1.14 and 1.13.

This issue can cause the compiler to crash. The compiler was checking an invariant that doesn't, and does not need to, hold.
@gopherbot gopherbot added the CherryPickCandidate label Jun 25, 2020
@gopherbot gopherbot mentioned this issue Jun 25, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.13 milestone Jun 25, 2020
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jun 25, 2020

Change https://golang.org/cl/239998 mentions this issue: [release-branch.go1.13] cmd/compile: remove check that Zero's arg has the correct base type

@dmitshur dmitshur mentioned this issue Jul 10, 2020
Closed
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 10, 2020

Backport approved for Go 1.14 (#39849) and 1.13 (this issue) because it's a small fix to a serious problem without a workaround.

@dmitshur dmitshur added CherryPickApproved and removed CherryPickCandidate labels Jul 10, 2020
gopherbot pushed a commit that referenced this issue Jul 10, 2020
@randall77 @dmitshur
[release-branch.go1.13] cmd/compile: remove check that Zero's arg has…
0b75fc7 
… the correct base type

It doesn't have to. The type in the aux field is authoritative.
There are cases involving casting from interface{} where pointers
have a placeholder pointer type (because the type is not known when
the IData op is generated).

The check was introduced in CL 13447.

Fixes #39848

Change-Id: Id77a57577806a271aeebd20bea5d92d08ee7aa6b
Reviewed-on: https://go-review.googlesource.com/c/go/+/239817
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit 3b2f67a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/239998
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 10, 2020

Closed by merging 0b75fc7 to release-branch.go1.13.

@andybons andybons removed this from the Go1.13.13 milestone Jul 14, 2020
@andybons andybons added this to the Go1.13.14 milestone Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.13.14
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot