Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: missing alt tags on gopher images in 3 pages #39861

Closed
nel417 opened this issue Jun 25, 2020 · 17 comments
Closed

x/website: missing alt tags on gopher images in 3 pages #39861

nel417 opened this issue Jun 25, 2020 · 17 comments

Comments

@nel417
Copy link

@nel417 nel417 commented Jun 25, 2020

What version of Go are you using (go version)?

go version go1.14.4 darwin/amd64

Does this issue reproduce with the latest release?

No, This is a website issue

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nl/Library/Caches/go-build"
GOENV="/Users/nl/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/nl/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3c/ddb5w67960nd39gnzw3mysqc0000gn/T/go-build542050604=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

A few pages on the Go website, Documents, Project, And Help, are scoring a 90 SEO and 93 accessibility because of missing alt tags. Via Lighthouse

What did you expect to see?

Images with alt tags

What did you see instead?

No alt tags, most pages have 100 accessibility and SEO, but these 3 pages were off.

@gopherbot gopherbot added this to the Unreleased milestone Jun 25, 2020
@cagedmantis cagedmantis changed the title x/website: x/website: missing alt tags Jun 25, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jun 25, 2020

/cc @dmitshur

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 25, 2020

Thanks. Since you already know specific pages that have problems, it would help a lot if you could mention them.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 25, 2020

A few pages on the Go website, Documents, Project, And Help,

From that description, I understand it's these URLs:

They are indeed missing alt attribute on the gopher images. Please let us know if I misunderstood, @nel417.

/cc @andybons

@dmitshur dmitshur changed the title x/website: missing alt tags x/website: missing alt tags on gopher images in 3 pages Jun 25, 2020
@nel417
Copy link
Author

@nel417 nel417 commented Jun 25, 2020

@dmitshur yes, looks perfect. Those are the images and URLs I was seeing that were missing a few alt tags.

@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 27, 2020

Made a change here : https://go-review.googlesource.com/c/website/+/240257

Not sure where the help file is located at. Any guidance would be appreciated.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2020

Change https://golang.org/cl/240257 mentions this issue: content/static/doc: added alt tags for images

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 27, 2020

Not sure where the help file is located at. Any guidance would be appreciated.

That file is still in the main Go repository, here.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2020

Change https://golang.org/cl/240258 mentions this issue: doc/help: Added alt-tags for accessibility

@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 27, 2020

Hi @dmitshur - thanks for the quick review. I made changes to the commit message and I think I got the tests passing now after running go generate golang.org/x/website/content/static. This seems to have made the failing tests pass, but I do not seem to have the ability to re-fire the trybots. Any guidance would be appreciated.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 27, 2020

Thank you. I can re-run the trybots now.

@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 28, 2020

Hi @dmitshur - Would you want the alt tag for the footer updated to also reflect a lowercase 'g'. i.e., change the alt tag from "The Go Gopher" to "The Go gopher" in the alt attribute for the footer on each page?

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 29, 2020

@nohe427 I didn't see there was already precedent for it on the same page, thanks for spotting that. Looks like it's not consistent with the blog post. Oh well, we're going with an empty string alt attribute, so let's not change other things for now.

@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 29, 2020

Hi @dmitshur - thanks for the quick turn around! Updated the specified pages with empty alt tags. Let me know if there is anything else needed before submitting.

@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 29, 2020

Thanks @dmitshur for the +2 to review. It seems I am unable to submit with the codereview. Is there something I am missing?

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 29, 2020

No worries, I can submit for you. (You can read more about Gerrit access here.) I just wanted to give you a chance to update the commit message if you wanted. I'll submit soon.

The update will be live on golang.org after the next time it's redeployed. The change in the /help/ file will take longer, because it's in the main Go repo, so it'll get updated when 1.15 is out.

@gopherbot gopherbot closed this in db85615 Jun 29, 2020
gopherbot pushed a commit to golang/website that referenced this issue Jun 29, 2020
This CL adds alt tags for the gopher images in docs, for better
accessibility. The HTML spec indicates that purely decorative images
have empty alt tags, hence, the empty alt tags here.

Fixes golang/go#39861

Change-Id: I5761e5c6c0005a6974e96a21263605fbfe8f27fc
Reviewed-on: https://go-review.googlesource.com/c/website/+/240257
Reviewed-by: Alexander Nohe <alex.nohe427@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@nohe427
Copy link
Contributor

@nohe427 nohe427 commented Jun 29, 2020

@dmitshur - ahh okay. Many thanks! Thank you for the quick reviews and turnaround time.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 29, 2020

Thank you for contributing a fix for this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.