Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: panic in fillstruct analyzer #39899
Oops, it appears that the reason fillstruct was implicated was that it was panicking, and the way I had structured my stress test led to other results hitting the cache, whereas fillstruct missed the cache due to the panic below.
We've since produces more generalized mayhem by updating the stress test to type more randomly...
Updated this issue to instead refer to the fillstruct panic.
The previous implementation missed a nil check which caused a panic when the package of a type was nil. Fixes: golang/go#39899 Change-Id: I2dfb50d6b79f52df367e093e5d857cd70b7cef27 Reviewed-on: https://go-review.googlesource.com/c/tools/+/240537 Run-TryBot: Josh Baum <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Rebecca Stambler <email@example.com> (cherry picked from commit aa3d501) Reviewed-on: https://go-review.googlesource.com/c/tools/+/240538 Run-TryBot: Rebecca Stambler <firstname.lastname@example.org> Reviewed-by: Josh Baum <email@example.com>