Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Add Github Gopherbot -> Gerrit review #39926

Closed
kush-patel-hs opened this issue Jun 29, 2020 · 4 comments
Closed

x/pkgsite: Add Github Gopherbot -> Gerrit review #39926

kush-patel-hs opened this issue Jun 29, 2020 · 4 comments

Comments

@kush-patel-hs
Copy link
Contributor

@kush-patel-hs kush-patel-hs commented Jun 29, 2020

What is the URL of the page with the issue?

What is your user agent?

N/A

Screenshot

N/A

What did you do?

Open a PR on Github for x/pkgsite

What did you expect to see?

Gopherbot imports the PR to Gerrit for code review

What did you see instead?

No import to Gerrit for code review

@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 29, 2020

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 29, 2020

Open a PR on Github for x/pkgsite

What was the PR you opened?

@kush-patel-hs
Copy link
Contributor Author

@kush-patel-hs kush-patel-hs commented Jun 29, 2020

Sorry I haven't opened one yet on GH (I just decided to use Gerrit), I saw this one though golang/pkgsite#1 which did not get sent to Gerrit.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 29, 2020

That PR was created at 2020-06-17T03:22:44Z and closed at 2020-06-17T03:23:01Z (17 seconds later). It may take GerritBot a minute or two to import a PR, so it looks like it just didn't get a chance to.

I don't think there's an issue here, you should be able to send either Gerrit CLs or GitHub PRs as documented at https://golang.org/wiki/GerritBot to contribute code changes. If you try it and run into a problem, please don't hesitate to reopen this issue or file a new one. Thanks.

@dmitshur dmitshur closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants