Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support fillstruct for "anonymous struct" struct fields #39929

Open
joshbaum opened this issue Jun 29, 2020 · 2 comments
Open

x/tools/gopls: support fillstruct for "anonymous struct" struct fields #39929

joshbaum opened this issue Jun 29, 2020 · 2 comments
Labels
Milestone

Comments

@joshbaum
Copy link

@joshbaum joshbaum commented Jun 29, 2020

The fix needs to be made in the analysisinternal package: https://github.com/golang/tools/blob/master/internal/analysisinternal/analysis.go#L113.

@gopherbot gopherbot added the Tools label Jun 29, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 29, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Jun 29, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 29, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 29, 2020

Change https://golang.org/cl/240463 mentions this issue: internal/lsp/analysis/fillstruct: permit anonymous structs to be filled

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.