Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: incorrect GC bitmap when global's type is in another shared object [1.14 backport] #39955

Open
gopherbot opened this issue Jun 30, 2020 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2020

@aclements requested issue #39927 to be considered for backport to the next 1.14 minor release.

@gopherbot, please backport to Go 1.14 and 1.15.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 30, 2020

@aclements Can you please include a short rationale about why the backport might be needed? (Per MinorReleases.) Thanks.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 1, 2020

Change https://golang.org/cl/240511 mentions this issue: [release-branch.go1.14] cmd/link: fix GC data reading from shared library (attempt 2)

@aclements
Copy link
Member

@aclements aclements commented Jul 1, 2020

Rationale for backport: This causes the garbage collector to incorrectly free reachable objects when using shared build mode, leading to memory corruption and crashes. There is no workaround (other than not using shared build mode).

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 10, 2020

Backport approved for Go 1.14 (this issue) and 1.13 (#39956) based on that rationale.

@gopherbot

This comment was marked as off-topic.

@andybons andybons modified the milestones: Go1.14.5, Go1.14.6, Go1.14.7 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.