Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't test error against poll.TimeoutError #39971

Closed
chuacw opened this issue Jul 1, 2020 · 2 comments
Closed

Can't test error against poll.TimeoutError #39971

chuacw opened this issue Jul 1, 2020 · 2 comments

Comments

@chuacw
Copy link

@chuacw chuacw commented Jul 1, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.4 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Administrator\AppData\Local\go-build
set GOENV=C:\Users\Administrator\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=K:\Development\Go\
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=K:\Development\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=K:\Development\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\ADMINI~1\AppData\Local\Temp\1\go-build426989442=/tm
p/go-build -gno-record-gcc-switches

What did you do?

    c, err := icmp.ListenPacket("ip6:ipv6-icmp", "::")
c.IPv6PacketConn().SetHopLimit(ttl)
c.IPv6PacketConn().SetControlMessage(ipv6.FlagHopLimit, true)
c.SetReadDeadline(time.Now().Add(30 * time.Millisecond))
rb := make([]byte, 1500)
    n, fromIP, err := c.ReadFrom(rb)

   if errors.Is(err, poll.TimeoutError) // this can't compile because poll.TimeoutError is internal
@D1CED
Copy link

@D1CED D1CED commented Jul 1, 2020

please take a look at #39798

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jul 1, 2020

You didn't say why you want to do that (i.e., this is an XY problem), but I would guess that what you are trying to do is fixed in the upcoming Go 1.15 release via the new error os.ErrDeadlineExceeded. See https://tip.golang.org/doc/go1.15#net and the SetDeadline method of https://tip.golang.org/pkg/net/#Conn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.