Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support fetching the latest and master versions of the standard library #39973

Open
julieqiu opened this issue Jul 1, 2020 · 5 comments

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 1, 2020

At the moment, stdlib.Zip only supports fetching a release version of the standard library.

We want stdlib.Zip to also support fetching the latest and master versions, for use in #37002 and #36811.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2020

Change https://golang.org/cl/240682 mentions this issue: internal/frontend: return 400 on @master requests for stdlib paths

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 1, 2020
At the moment, we do not support requests to @master for packages in the
standard library. Until that support is added, return a 400 for those
requests, instead of showing a 404 page where the user could attempt to
fetch the path.

fetchAndPoll is also updated to return a 400 on requests to @master and
@latest for packages in the standard library.

Updates golang/go#36811
Updates golang/go#39973

Change-Id: I372ad2686547278754f2c04e69ddea7fc092df34
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240682
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@kush-patel-hs
Copy link
Contributor

@kush-patel-hs kush-patel-hs commented Jul 1, 2020

I can change stdlib.Zip!

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 6, 2020

Change https://golang.org/cl/241042 mentions this issue: internal/stdlib,internal/fetch: support fetching the latest and master versions of stdlib in stdlib.Zip

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241272 mentions this issue: internal: move Latest, Master constants to version package

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 9, 2020

Change https://golang.org/cl/241604 mentions this issue: internal/stdlib,internal/fetch: support fetching the latest version of stdlib in stdlib.Zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.