Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: support fetching the latest and master versions of the standard library #39973

Closed
julieqiu opened this issue Jul 1, 2020 · 8 comments
Closed

x/pkgsite: support fetching the latest and master versions of the standard library #39973

julieqiu opened this issue Jul 1, 2020 · 8 comments
Labels
NeedsFix Suggested go.dev help wanted pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 1, 2020 •
edited

At the moment, stdlib.Zip only supports fetching a release version of the standard library.

We want stdlib.Zip to also support fetching the latest and master versions, for use in #37002 and #36811.
@gopherbot gopherbot added this to the Unreleased milestone Jul 1, 2020
@julieqiu julieqiu added pkgsite NeedsFix help wanted Suggested labels Jul 1, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2020

Change https://golang.org/cl/240682 mentions this issue: internal/frontend: return 400 on @master requests for stdlib paths
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 1, 2020
@julieqiu
internal/frontend: return 400 on @master requests for stdlib paths
1c9741e 
At the moment, we do not support requests to @master for packages in the
standard library. Until that support is added, return a 400 for those
requests, instead of showing a 404 page where the user could attempt to
fetch the path.

fetchAndPoll is also updated to return a 400 on requests to @master and
@latest for packages in the standard library.

Updates golang/go#36811
Updates golang/go#39973

Change-Id: I372ad2686547278754f2c04e69ddea7fc092df34
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240682
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@kush-patel-hs
Copy link
Contributor

@kush-patel-hs kush-patel-hs commented Jul 1, 2020

I can change stdlib.Zip!
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 6, 2020

Change https://golang.org/cl/241042 mentions this issue: internal/stdlib,internal/fetch: support fetching the latest and master versions of stdlib in stdlib.Zip
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241272 mentions this issue: internal: move Latest, Master constants to version package
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 9, 2020

Change https://golang.org/cl/241604 mentions this issue: internal/stdlib,internal/fetch: support fetching the latest version of stdlib in stdlib.Zip
gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 7, 2020
@julieqiu
internal: support fetching the latest version of stdlib
af71a9b 
This change adds support for resolving the latest version of the std
module, using stdlib.Zip.

Updates golang/go#39973

Change-Id: I0e27303bf2290f67c9dbc80fadf66b2e5c73e886
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/241604
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 7, 2020

Change https://golang.org/cl/247398 mentions this issue: internal/stdlib: add semverForVersion
gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 7, 2020
@julieqiu
internal/stdlib: add semanticVersion function
6ff8945 
Logic for resolving the semantic version in Zip is moved to the
function semanticVersion.

For golang/go#39973

Change-Id: I5c9215a4cc326d2a9c5db79f33509656ec0b0065
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/247398
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/unreleased Aug 27, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@kirandasika98
Copy link

@kirandasika98 kirandasika98 commented Dec 19, 2020

Hi @julieqiu , Can I pick up the task to support fetching from master?
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 19, 2020

Change https://golang.org/cl/279292 mentions this issue: internal/stdlib: added ability to fetch master version
@gopherbot gopherbot closed this in golang/pkgsite@db1cada Jan 19, 2021
@julieqiu julieqiu mentioned this issue Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested go.dev help wanted pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@julieqiu @kirandasika98 @gopherbot @kush-patel-hs