Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: standard library packages should not use upper-case paths #40065

Closed
rsc opened this issue Jul 6, 2020 · 4 comments
Closed

all: standard library packages should not use upper-case paths #40065

rsc opened this issue Jul 6, 2020 · 4 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Jul 6, 2020

crypto/x509/internal/macOS was added on May 7.
It is the first standard library package with upper-case letters.
They should be lowercased, following the standard all-lower-case convention.
(For example it is syscall/internal/windows not syscall/internal/Windows.)

I believe this is the only one, but if there are others, they should be fixed too.

@rsc rsc added this to the Go1.15 milestone Jul 6, 2020
@crawshaw
Copy link
Contributor

@crawshaw crawshaw commented Jul 6, 2020

Two other directories but they are not actual packages:

find . -type d -name "*[A-Z]*"
./cmd/link/testdata/testIndexMismatch
./cmd/link/testdata/testBuildFortvOS
./crypto/x509/internal/macOS
@robpike robpike changed the title all: standard library packages should not use upper-case all: standard library packages should not use upper-case paths Jul 6, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 6, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241274 mentions this issue: crypto/x509/internal/macos: rename package to lowercase

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 13, 2020

Change https://golang.org/cl/241878 mentions this issue: crypto/x509/internal/macos: rename package name to lowercase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.