Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
net: remove dependency on fmt, unicode via golang.org/x/net/dns/dnsmessage #40070
net should not depend on fmt and unicode.
golang.org/x/net/dns/dnsmessage contains one line using fmt:
But dnsmessage is vendored into the standard library and imported by net,
This one line should be changed, to remove the use of fmt.
go/build.TestDependencies claims to check that net does not
I have a fix that I will send out for that problem as well.
This package cannot use fmt, because standard package net imports it. (Most of the package is already clean, including Type.String.) For golang/go#40070. Change-Id: I9be92e98d9f5dcfb26852d38004e05f07df5e17a Reviewed-on: https://go-review.googlesource.com/c/net/+/241085 Run-TryBot: Russ Cox <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Dmitri Shuralyov <firstname.lastname@example.org>
TestDependencies defines the dependency policy (what can depend on what) for the standard library. The standard library has outgrown the idea of writing the policy as a plain map literal. Also, the checker was ignoring vendored packages, which makes it miss real problems. This commit adds a little language for describing partial orders and rewrites the policy in that language. It also changes the checker to look inside vendored packages and adds those to the policy as well. This turned up one important problem: net is depending on fmt, unicode via golang.org/x/net/dns/dnsmessage, filed as #40070. This is a test-only change, so it should be appropriate even for the release freeze, especially since it identified a real bug. Change-Id: I9b79f30761f167b8587204c959baa973583e39f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/241078 Run-TryBot: Russ Cox <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com>