Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: include GOMODCACHE in documented list of environment variables #40089

Closed
dmitshur opened this issue Jul 7, 2020 · 3 comments
Closed

cmd/go: include GOMODCACHE in documented list of environment variables #40089

dmitshur opened this issue Jul 7, 2020 · 3 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jul 7, 2020

Go 1.15 adds the GOMODCACHE environment variable (#34527). It's mentioned in the release notes (CL 230537). Should it also be included in the list at https://tip.golang.org/cmd/go/#hdr-Environment_variables?

/cc @jayconrod @matloob @bcmills

@tpaschalis
Copy link
Contributor

@tpaschalis tpaschalis commented Jul 7, 2020

If it's included, would it go under General-purpose environment variables? Could I suggest something like

GOMODCACHE
	The directory where the go command will cache module downloads. 
	It defaults to GOPATH/pkg/mod.
@jayconrod jayconrod self-assigned this Jul 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241275 mentions this issue: cmd/go: include GOMODCACHE in 'go help environment'

@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Jul 8, 2020
@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Jul 9, 2020

There's a CL out to fix this (that just needs review), I think we don't want to release Go 1.15 without this, so marking release-blocker so this isn't missed by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.