Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add function to set up frontend server #40096

Open
julieqiu opened this issue Jul 7, 2020 · 3 comments
Open

x/pkgsite: add function to set up frontend server #40096

julieqiu opened this issue Jul 7, 2020 · 3 comments
Labels
NeedsFix pkgsite

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 7, 2020

There are several places in the code where we set up a frontend.NewServer:

It would be useful to factor out shared parts of this code to reduce duplication.

@julieqiu julieqiu added NeedsFix pkgsite labels Jul 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 7, 2020
@laches1sm
Copy link

@laches1sm laches1sm commented Jul 7, 2020

I'd be happy to try and take on this issue - I'll have a look at the code you provided in the issue and try and refactor it.

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jul 7, 2020

Please do! As a heads up, I'm about to merge https://go-review.googlesource.com/c/pkgsite/+/240946, which will move around some of the code in internal/testing/integration/frontend_test.go.

@laches1sm
Copy link

@laches1sm laches1sm commented Jul 7, 2020

Awesome, I'll have a wee look at the updated code as soon as you merge :) thank you!

@julieqiu julieqiu removed this from the Unreleased milestone Aug 27, 2020
@julieqiu julieqiu added this to the pkgsite/unreleased milestone Aug 27, 2020
@julieqiu julieqiu removed the website label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants