We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are several places in the code where we set up a frontend.NewServer:
frontend.NewServer
cmd/frontend
internal/frontend/server_test.go
internal/testing/integration/frontend_test.go
It would be useful to factor out shared parts of this code to reduce duplication.
The text was updated successfully, but these errors were encountered:
I'd be happy to try and take on this issue - I'll have a look at the code you provided in the issue and try and refactor it.
Sorry, something went wrong.
Please do! As a heads up, I'm about to merge https://go-review.googlesource.com/c/pkgsite/+/240946, which will move around some of the code in internal/testing/integration/frontend_test.go.
Awesome, I'll have a wee look at the updated code as soon as you merge :) thank you!
No branches or pull requests
There are several places in the code where we set up a
frontend.NewServer
:cmd/frontend
: https://github.com/golang/pkgsite/blob/master/cmd/frontend/main.go#L94-L123internal/frontend/server_test.go
: https://github.com/golang/pkgsite/blob/master/internal/frontend/server_test.go#L990-L1031internal/testing/integration/frontend_test.go
: https://github.com/golang/pkgsite/blob/master/internal/testing/integration/frontend_test.go#L155-L167It would be useful to factor out shared parts of this code to reduce duplication.
The text was updated successfully, but these errors were encountered: