Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add function to set up queue #40097

Closed
julieqiu opened this issue Jul 7, 2020 · 3 comments
Closed

x/pkgsite: add function to set up queue #40097

julieqiu opened this issue Jul 7, 2020 · 3 comments
Labels
NeedsFix Suggested help wanted pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 7, 2020

We use the same newQueue logic in cmd/frontend and cmd/worker:

It would be nice to have a single function to reduce duplication.
@julieqiu julieqiu added Suggested help wanted NeedsFix pkgsite labels Jul 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 7, 2020
@akolar
Copy link

@akolar akolar commented Jul 7, 2020

Mind if I take a stab at this?
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jul 7, 2020

Please do!
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 8, 2020

Change https://golang.org/cl/241477 mentions this issue: internal/queue: refactor existing queue creators into queue.New
@gopherbot gopherbot closed this in golang/pkgsite@7a5705b Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Suggested help wanted pkgsite
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@julieqiu @akolar @gopherbot