Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add function to set up test queue #40098

Closed
julieqiu opened this issue Jul 7, 2020 · 6 comments
Closed

x/pkgsite: add function to set up test queue #40098

julieqiu opened this issue Jul 7, 2020 · 6 comments

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 7, 2020

There are a couple of places in the code where we want to set up a queue for testing:

It would be useful to have a single setupQueue function for use in testing.

@tayoogunbiyi
Copy link

@tayoogunbiyi tayoogunbiyi commented Jul 8, 2020

It would be useful to have a single setupQueue function for use in testing.

The link for where the code is duplicated within internal/testing/integration/frontend_test.go is https://github.com/golang/pkgsite/blob/master/internal/testing/integration/frontend_test.go#L205-L211

@amarjeetanandsingh
Copy link

@amarjeetanandsingh amarjeetanandsingh commented Jul 14, 2020

@julieqiu
May I give it a try?

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jul 20, 2020

@amarjeetanandsingh please do!

@BLasan
Copy link

@BLasan BLasan commented Aug 5, 2020

@julieqiu Can I work on this?

@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 22, 2020
@ya5u
Copy link

@ya5u ya5u commented Jan 30, 2021

@julieqiu queue.InMemory seems to be working effectively as a test helper and to be invoked by no other than test code. Isn't it necessary to create another function?

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Feb 2, 2021

Nope - this issue seems to be outdated. Thanks for taking a look!

@julieqiu julieqiu closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants