Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp/regtest: regression tests for on-disk file changes failing on darwin builders #40099

Open
dmitshur opened this issue Jul 7, 2020 · 5 comments
Labels
gopls NeedsInvestigation Testing Tools
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 7, 2020

The test added in CL 238917 are not passing on darwin builders:

image

(From https://build.golang.org/?repo=golang.org%2fx%2ftools.)

The errors mention "context deadline exceeded" and the tests are running for over 8 minutes:

[...]
            runner.go:210: Shutdown: context deadline exceeded
FAIL
FAIL	golang.org/x/tools/internal/lsp/regtest	530.597s

/cc @stamblerre

@dmitshur dmitshur added NeedsInvestigation Tools labels Jul 7, 2020
@dmitshur dmitshur added this to the Unreleased milestone Jul 7, 2020
@gopherbot gopherbot added the gopls label Jul 7, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 7, 2020
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Jul 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241276 mentions this issue: internal/lsp/regtest: await IWL before running tests

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 8, 2020

Looks like my CL still hasn't fixed the issue. I believe that this is the same builder that is mentioned in #39802, and I'm not sure how to debug this further given that it is specific to this builder. I suppose I can try using Gomote, but before I do that, @dmitshur, are there any known issues with that builder?

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Jul 8, 2020

are there any known issues with that builder?

I can't think of anything relevant off the top of my head, and the "notes" field at https://farmer.golang.org/builders is empty. In general, the darwin builders are known to be somewhat more troublesome compared to some other builders, and "darwin-amd64-10_12" is the oldest darwin builder. (The older a builder, the more likely it is to have problems that might be fixed in newer versions.) If this turns out to be a builder problem, we should try to fix it or document it. /cc @cagedmantis @toothrot

Debugging via a Gomote should be a good way to try learn more.

@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jul 22, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 22, 2020
@andybons
Copy link
Member

@andybons andybons commented Aug 10, 2020

Bumping this up as other failures may be hidden by this if they’re not fixed.

We should investigate further using gomote and if no underlying cause can be found soon, we should at least disable the test with a bug to track re-enabling it.

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 12, 2020

Yep, sorry about the delay, I plan to take a look at this soon. We shouldn't disable the tests though, because this is clearly a problem specific to one builder.

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Aug 12, 2020
@stamblerre stamblerre added this to the gopls/v.0.4.5 milestone Aug 12, 2020
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Aug 27, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 27, 2020
@stamblerre stamblerre added the Testing label Aug 27, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Testing in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Jan 16, 2021
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 16, 2021
@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Jan 20, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls NeedsInvestigation Testing Tools
Projects
No open projects
Development

No branches or pull requests

5 participants