Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: Gerrit new patchset comments break SlowBots #40106

Closed
FiloSottile opened this issue Jul 7, 2020 · 2 comments
Closed

x/build: Gerrit new patchset comments break SlowBots #40106

FiloSottile opened this issue Jul 7, 2020 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone

Comments

@FiloSottile
Copy link
Contributor

The Gerrit UI switched from change messages to patchset comments. This broke SlowBots because they look for the TRY= line only in change messages.

https://go-review.googlesource.com/c/go/+/241274/2#message-0074141e27123306d3396d09a5d3215ce2413706

@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 7, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 7, 2020
@dmitshur dmitshur added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Jul 7, 2020
@dmitshur dmitshur self-assigned this Jul 7, 2020
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Jul 7, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Jul 7, 2020

I've looked into this and know what needs to be done to restore service. Roughly:

  • update maintapi to extract TRY= comments from inline comments (where they now end up)
    • add List Change Comments to x/build's gerrit API client package, use it to fetch inline comments
      • confirmed inline comments are not tracked in the maintner corpus; so must use Gerrit API
      • confirmed inline comments are not already available via QueryChanges API call; need this endpoint
    • modify logic in tryWorkItem
  • redeploy maintnerd

Working on a fix CL.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/241323 mentions this issue: maintner/maintnerd/maintapi: look for TRY= in inline comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Development

No branches or pull requests

4 participants
@FiloSottile @dmitshur @gopherbot and others