Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/pkgsite: in cmd/frontend's --proxy_url argument, exclude localhost from https requirement #40123
What did you do?
I tried to start
I want to use
What did you expect to see?
pkgsite/cmd/frontend starts without errors using
What did you see instead?
The below fatal error:
In https://github.com/golang/pkgsite/blob/master/internal/proxy/client.go#L53 if we exclude localhost from the https requirement, that would solve my immediate problem.
But later on, if we want to move athens and pkgsite into their own separate deployments, I'll have to point pkgsite to
If we want to allow all such internal communications, another option would be to resolve the hostname, and if it is in a private IP address range, then don't expect https. But I'm not sure if that would have implications in other private IP situations.