Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot, x/build/maintner: "close stale WaitingForInfo" task failing on non-existing issue #40149

Open
dmitshur opened this issue Jul 10, 2020 · 0 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jul 10, 2020

From gopherbot logs:

2020/07/10 13:33:30 close stale WaitingForInfo: POST https://api.github.com/repos/golang/go/issues/39453/comments: 422 Validation Failed [{Resource:IssueComment Field:data Code:unprocessable Message:Could not resolve to a node with the global id of 'MDU6SXNzdWU2MzM4NzY4NTM='.}]
2020/07/10 13:33:30 gopherbot ran in 9.88987365s

Issue #39453 is 404. gopherbot should handle this situation as a non-error. Treating it as an error adds an unnecessary sleep:

2020/07/10 13:33:30 sleeping 30s after previous error.

It's possible this is a bug or unexpected behavior on the GitHub API side (might be worth reporting it to them), but if it persists, we should just update gopherbot to handle it.

It's also worth investigating if this is an issue that can and is better to fix in maintner, rather than gopherbot.

/cc @golang/osp-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants