Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: size of the top banner #40181

Closed
nanokatze opened this issue Jul 12, 2020 · 2 comments
Closed

x/pkgsite: size of the top banner #40181

nanokatze opened this issue Jul 12, 2020 · 2 comments
Milestone

Comments

@nanokatze
Copy link

@nanokatze nanokatze commented Jul 12, 2020

I find the banner at the top of every page following me around as I scroll the page make the experience somewhat claustrophobic. Would it be possible to make it somewhat shorter and/or have it not be stuck to my viewport as I scroll, similar to how it currently is on godoc.org?

What is the URL of the page with the issue?

Any, for example https://pkg.go.dev/golang.org/x/tools/cmd/goyacc?tab=doc

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0

Screenshot

The screen the following was observed on is a 1920×1080 of a 14" laptop computer (Thinkpad T460). Firefox has its layout.css.devPixelsPerPx parameter set to a random value of 1.42 to account for the increased pixel density but even on 96ppi screen with default settings the banner is still somewhat annoying.

gnome-shell-screenshot-G0CNN0

What did you expect to see?

gnome-shell-screenshot-LUIGN0

@gopherbot gopherbot added this to the Unreleased milestone Jul 12, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Jul 12, 2020

Thanks for the report. This was already reported as #37110, so I'm closing here in favour of the older thread.

@ALTree ALTree closed this Jul 12, 2020
@nanokatze
Copy link
Author

@nanokatze nanokatze commented Jul 12, 2020

Oops, sorry, my bad for not finding the dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants