Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: fix badge image and pkg.go.dev link URLs in badge generation tool #40216

Closed
jamalc opened this issue Jul 14, 2020 · 2 comments
Closed

x/pkgsite: fix badge image and pkg.go.dev link URLs in badge generation tool #40216

jamalc opened this issue Jul 14, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@jamalc
Copy link
Member

@jamalc jamalc commented Jul 14, 2020

What did you do?

Generating badges using the badge generation tool (https://pkg.go.dev/badge).

For example, generating a badge for the URL:

https://pkg.go.dev/net/url?tab=overview

What did you expect to see?

It should produce the following markdown snippet:

[![PkgGoDev](https://pkg.go.dev/badge/net/url?tab=overview)](https://pkg.go.dev/net/url?tab=overview)

What did you see instead?

And instead produces this snippet:

[![PkgGoDev](https://pkg.go.dev/net/url?tab=overview)](https://pkg.go.dev/badge/net/url?tab=overview)

@jamalc jamalc self-assigned this Jul 14, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 14, 2020

Change https://golang.org/cl/242641 mentions this issue: content,internal: fix markdown badge snippet

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 15, 2020

Change https://golang.org/cl/242737 mentions this issue: content/static: fix badge dynamic update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants