Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: consolidate keyboard shortcut behavior across site #40246

Open
andybons opened this issue Jul 16, 2020 · 3 comments
Open

x/pkgsite: consolidate keyboard shortcut behavior across site #40246

andybons opened this issue Jul 16, 2020 · 3 comments
Labels
Milestone

Comments

@andybons
Copy link
Member

@andybons andybons commented Jul 16, 2020

There are few places where we handle keyboard shortcuts on the site, and these should be consolidated into a sensible design to more easily avoid conflicts and code duplication.

@gopherbot gopherbot added this to the Unreleased milestone Jul 16, 2020
@AceroM
Copy link

@AceroM AceroM commented Jul 16, 2020

In most popular websites (reddit, github etc...) typing "?" would bring up a dialog to list available keyboard shortcuts, would this be something we can consider?

@andybons
Copy link
Member Author

@andybons andybons commented Jul 16, 2020

@AceroM That exists right now at least on the Doc tab. It seems to make sense to have it on other pages, but that’s not really what this issue is about.

@andybons andybons assigned andybons and unassigned andybons Jul 16, 2020
@andybons
Copy link
Member Author

@andybons andybons commented Jul 16, 2020

Apologies @AceroM as I didn’t exactly clarify what this issue was about 😄 .

This issue is about coming up with a solid architecture design on the frontend for handling keyboard shortcuts in code. It’s not focused on visual design or UI elements on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.