Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: clarify expected input on #40258

ostcar opened this issue Jul 16, 2020 · 2 comments

x/pkgsite: clarify expected input on #40258

ostcar opened this issue Jul 16, 2020 · 2 comments
help wanted NeedsFix pkgsite


Copy link

@ostcar ostcar commented Jul 16, 2020

What is the URL of the page with the issue?

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0



What did you do?

Open the page.

What did you expect to see?

The form-field called URL should either be called package or accept an URL with an (https-)schema.

What did you see instead?

The Form-Field is called URL, but if you paste an URL with an protocol-schema, it creates an invalid link to

The example text in the empty form-field (when empty) shows an example URL with an schema. This example creates an invalid badge.

I already reported it here but was ask to create a new issue.

@gopherbot gopherbot added this to the Unreleased milestone Jul 16, 2020
@andybons andybons added NeedsInvestigation pkgsite labels Jul 16, 2020
Copy link

@julieqiu julieqiu commented Jul 17, 2020

/cc @jamalc

Copy link

@jamalc jamalc commented Jul 17, 2020

We chose to label the input "URL" to clarify that the tool is not limited to packages. The form does accept full URLs but the schema and host are trimmed from the input box once they are submitted. On second look that may be somewhat misleading.

It could be a better experience to keep the full URL in the input box after the badge is created OR to label the input something like Path and clarify that it can be any URL path and is not limited to packages. I think in any case we should accept full URL or a path as input.

@jamalc jamalc added help wanted NeedsFix and removed NeedsInvestigation labels Jul 17, 2020
@julieqiu julieqiu changed the title x/pkgsite: Generator field is called URL but expect an package name x/pkgsite: clarify expected input on Jul 29, 2020
@julieqiu julieqiu reopened this Aug 6, 2020
@golang golang deleted a comment from gopherbot Aug 7, 2020
@julieqiu julieqiu removed this from the Unreleased milestone Aug 27, 2020
@julieqiu julieqiu added this to the pkgsite/unreleased milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
help wanted NeedsFix pkgsite
None yet

No branches or pull requests

6 participants