x/pkgsite: clarify expected input on pkg.go.dev/badge #40258
What is the URL of the page with the issue?
What is your user agent?
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0
What did you do?
Open the page.
What did you expect to see?
The form-field called
What did you see instead?
The Form-Field is called URL, but if you paste an URL with an protocol-schema, it creates an invalid link to pkg.go.dev.
The example text in the empty form-field (when empty) shows an example URL with an schema. This example creates an invalid badge.
I already reported it here but was ask to create a new issue.
The text was updated successfully, but these errors were encountered:
We chose to label the input "URL" to clarify that the tool is not limited to packages. The form does accept full URLs but the schema and host are trimmed from the input box once they are submitted. On second look that may be somewhat misleading.
It could be a better experience to keep the full URL in the input box after the badge is created OR to label the input something like Path and clarify that it can be any pkg.go.dev URL path and is not limited to packages. I think in any case we should accept full URL or a pkg.go.dev path as input.
CMakeLists.txt currently tries to include /x/sys/cpu/cpu_gccgo.c which is no longer there, thus causing build to fail for x86 platform architecture. This updates CMakeLists.txt to import correct C file from the golang/sys package which is cpu_gccgo_x86.c from x86. Fixes golang/go#40258 Change-Id: I80be54daee277a53906031b3f69772defd5f853f Reviewed-on: https://go-review.googlesource.com/c/gollvm/+/246318 Reviewed-by: Cherry Zhang <firstname.lastname@example.org>