Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: crashes on gitlens files #40272
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.
Please attach the stack trace from the crash.
panic: only file URIs are supported, got "gitlens" from "gitlens://7d8440e/home/nakama/workspace/tokopedia/rechargeapp?%7B%22path%22%3A%22%2Fhome%2Fnakama%2Fworkspace%2Ftokopedia%2Frechargeapp%22%2C%22ref%22%3A%227d8440ea48c374823952895e01eddef8328d2a3f%22%2C%22repoPath%22%3A%22%2Fhome%2Fnakama%2Fworkspace%2Ftokopedia%2Frechargeapp%22%7D"
goroutine 90 [running]:
OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.
NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
<OPTIONAL: ATTACH LOGS HERE>
yes it's true, when opening changes with previous revision, I accidentally pressed
The thing is, I don't know how to "undo" that state and return to normal state and from eamodio/vscode-gitlens#997 the gitlens itself stated that you cannot return to normal state, thus gopls will stuck in its panic state right at the start of vscode running and renders it unusable.
It's a certainty that this gopls and gitlens have something ...
Not sure how much
There are other document schemes https://github.com/eamodio/vscode-gitlens/blob/master/src/constants.ts#L54 but I don't know how others interact with editors and potentially triggers requests to the language server.
We can prevent crashing on non-file URIs by checking the URIs of the workspace folders, as well as the root URI. Updates golang/go#40272 Change-Id: Ieddc6d6053fbb3d61e4c26fc8831c092328f6f33 Reviewed-on: https://go-review.googlesource.com/c/tools/+/244602 Run-TryBot: Rebecca Stambler <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Heschi Kreinick <firstname.lastname@example.org>