Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: completing inside `new()` suggests keywords first #40274

Open
muirdm opened this issue Jul 17, 2020 · 1 comment
Open

x/tools/gopls: completing inside `new()` suggests keywords first #40274

muirdm opened this issue Jul 17, 2020 · 1 comment

Comments

@muirdm
Copy link

@muirdm muirdm commented Jul 17, 2020

package main

func main() {
	var _ *int = new()
}

Completing inside new() should offer int first, but it instead offers chan, func, map, and then int.

Probably addKeywordCompletions shouldn't add keyword type name candidates if there is already an expected type (int is the expected type in the above example).

@gopherbot gopherbot added this to the Unreleased milestone Jul 17, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 2, 2020

Change https://golang.org/cl/246360 mentions this issue: internal/lsp/source: improve unnamed type completion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.