Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: internal/postgres.BenchmarkSearch failing #40285

Closed
amarjeetanandsingh opened this issue Jul 18, 2020 · 2 comments
Closed

x/pkgsite: internal/postgres.BenchmarkSearch failing #40285

amarjeetanandsingh opened this issue Jul 18, 2020 · 2 comments

Comments

@amarjeetanandsingh
Copy link

@amarjeetanandsingh amarjeetanandsingh commented Jul 18, 2020

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/amar/Library/Caches/go-build"
GOENV="/Users/amar/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/amar/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/amar/oss/pkgsite/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nr/2l1z8c_152s8x6tsb9xsb4t40000gq/T/go-build719961911=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

go test -run=^$ -bench=BenchmarkSearch ./internal/postgres

What did you expect to see?

Pass BenchmarkSearch

What did you see instead?

--- FAIL: BenchmarkSearch
  benchmarks_test.go:43: database.Open("pgx", "user='postgres' password=REDACTED host='localhost' port=5432 dbname='discovery-db' sslmode=disable options='-c statement_timeout=600000'"): sql: unknown driver "pgx" (forgotten import?)

/cc @julieqiu

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2020
@amarjeetanandsingh amarjeetanandsingh changed the title x/pkgsite: internal/postgres/BenchmarkSearch failing x/pkgsite: internal/postgres.BenchmarkSearch failing Jul 18, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 18, 2020

Change https://golang.org/cl/243437 mentions this issue: internal/postgres: fix for BenchmarkSearch

@toothrot
Copy link
Contributor

@toothrot toothrot commented Jul 21, 2020

/cc @julieqiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants