Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: remove github.com/dsyx/serial-go #40305

Closed
dsyx opened this issue Jul 20, 2020 · 6 comments
Closed

x/pkgsite: remove github.com/dsyx/serial-go #40305

dsyx opened this issue Jul 20, 2020 · 6 comments

Comments

@dsyx
Copy link

@dsyx dsyx commented Jul 20, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/dsyx/serial-go?tab=doc

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36 Edg/84.0.522.40

Screenshot

image

What did you do?

This is my package, but after I changed the name, its old copy is still on go.dev. In fact, the module address pointed to by this packet is invalid.

What did you expect to see?

I think go.dev should remove it. go.dev should remove such non-existent modules.

@gopherbot gopherbot added this to the Unreleased milestone Jul 20, 2020
@toothrot toothrot added the pkgsite label Jul 21, 2020
@toothrot toothrot changed the title x/pkgsite: Should remove non-existent packages x/pkgsite: remove github.com/dsyx/serial-go Jul 21, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Jul 21, 2020

/cc @julieqiu

@dsyx
Copy link
Author

@dsyx dsyx commented Jul 22, 2020

I don't think the title should be changed. In theory, this will happen to all renamed packages. @toothrot

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 24, 2020

Removed. https://pkg.go.dev/github.com/dsyx/serial-go should now return a 404.

@julieqiu julieqiu closed this Jul 24, 2020
@dsyx
Copy link
Author

@dsyx dsyx commented Jul 25, 2020

If other Go packages change their names, will this phenomenon still happen? @julieqiu

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 25, 2020

Yes - package authors will need to notify us when they want a package removed. See a related comment on this topic here: #38897 (comment)

@dsyx
Copy link
Author

@dsyx dsyx commented Jul 25, 2020

Thanks. Will go.dev automatically delete non-existent packages in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants