Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design draft: placeholder #40307

Closed
katiehockman opened this issue Jul 20, 2020 · 3 comments
Closed

design draft: placeholder #40307

katiehockman opened this issue Jul 20, 2020 · 3 comments
Labels
Milestone

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Jul 20, 2020

Issue number reserved for design draft - will be welcoming feedback soon

For right now, please direct feedback to the existing Reddit thread: https://www.reddit.com/r/golang/comments/hvpr96/design_draft_first_class_fuzzing

@gopherbot gopherbot added this to the Proposal milestone Jul 20, 2020
@gopherbot gopherbot added the Proposal label Jul 20, 2020
@katiehockman katiehockman changed the title proposal: placeholder design draft: placeholder Jul 21, 2020
@tv42
Copy link

@tv42 tv42 commented Jul 22, 2020

F.BadInput documentation should include language similar to F.Fatal. The example clearly uses it for control flow, and the current documentation hints at that, but it should be made clear like F.Fatal.

@tv42
Copy link

@tv42 tv42 commented Jul 22, 2020

Fuzzing of built-in types (e.g. simple types, maps, arrays) and types which implement the BinaryMarshaler and TextMarshaler interfaces are supported.

That should include corresponding XxxUnmarshaler interfaces or you won't be able to load them back from files; the Implementation section gets that right, which might be a sign of unnecessary duplication. Suggestion: define the concept fuzzable type once, don't repeat.

By the time this proposal makes it to actual docs, definition of fuzzable types should explicitly state that the combination of built-in types with marshalable fields/values/etc are fuzzable too. Right now that is merely implied.

@golang golang locked as off topic and limited conversation to collaborators Jul 22, 2020
@katiehockman
Copy link
Member Author

@katiehockman katiehockman commented Jul 22, 2020

Closing this issue, since discussion will now be at https://golang.org/s/draft-fuzzing-reddit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.