Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/pkgsite: Google Tag Manager is loaded twice #40321
The following snippet:
Is meant to replace the following:
As I understand it, this was done for security reasons.
There was an attempt to create a noscript tag, which only runs when JS is disabled, using JS. Remove it. For golang/go#40321. Change-Id: I99c02810ed7c299fb606259823ef9b764c525bb6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/243858 Reviewed-by: Julie Qiu <email@example.com>
I am not the expert, but I think you can use nonces, as long as you wire them through the template so they only get applied where you intend them to be applied. I can review a CL that introduces nonces if you'd like.