Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: move circular dependency tests to regression tests #40332

Closed
stamblerre opened this issue Jul 21, 2020 · 1 comment
Closed

x/tools/gopls: move circular dependency tests to regression tests #40332

stamblerre opened this issue Jul 21, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 21, 2020

These have always been finicky, and there are some special cases just for those tests. I think they would work better as regression tests.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 22, 2020

Change https://golang.org/cl/272207 mentions this issue: gopls/internal/regtest: convert circular import tests to regtests

vscode-go: gopls by default automation moved this from Testing to Done Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants