Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add checks to all.bash for JS compile errors #40333

Closed
julieqiu opened this issue Jul 21, 2020 · 1 comment
Closed

x/pkgsite: add checks to all.bash for JS compile errors #40333

julieqiu opened this issue Jul 21, 2020 · 1 comment

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 21, 2020

At the moment, the all.bash does not check for any common JS issues, such as an undefined variable or type errors. We should add steps to help catch these issues to the all.bash.

/cc @andybons @jba @jamalc

@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@jamalc jamalc self-assigned this Feb 26, 2021
@jamalc
Copy link
Member

@jamalc jamalc commented Feb 26, 2021

We now have these checks as part of the work from #40960.

@jamalc jamalc closed this Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants