Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add checks to all.bash for JS compile errors #40333

Open
julieqiu opened this issue Jul 21, 2020 · 0 comments
Open

x/pkgsite: add checks to all.bash for JS compile errors #40333

julieqiu opened this issue Jul 21, 2020 · 0 comments
Labels
NeedsInvestigation pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jul 21, 2020

At the moment, the all.bash does not check for any common JS issues, such as an undefined variable or type errors. We should add steps to help catch these issues to the all.bash.

/cc @andybons @jba @jamalc
@gopherbot gopherbot added this to the Unreleased milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation pkgsite
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@julieqiu @gopherbot
You can’t perform that action at this time.