x/tools/gopls: don't recreate the view when a go.mod file is created #40340
Comments
Change https://golang.org/cl/245818 mentions this issue: |
This is likely related to the flake seen here: https://storage.googleapis.com/go-build-log/ba9e1088/linux-386_f12e4b30.log. |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Sep 1, 2020
Also, add a directory parameter to RunGoCommand. To make sure that the parameters aren't misused, change args to a []string. Updates golang/go#40340 Change-Id: Ib5ce606a401a18c29c904b570ec9339f067a3961 Reviewed-on: https://go-review.googlesource.com/c/tools/+/245818 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
Change https://golang.org/cl/260078 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This caused golang/vscode-go#363, because a
go.mod
was being created during that test, and the completion request was reaching the server at the time that the view was shutting down.We either need to handle such a situation more gracefully, or we shouldn't shut down a view on
go.mod
creation. That would mean putting a mutex around a lot of the view's fields that we treat as immutable.The text was updated successfully, but these errors were encountered: