Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: don't recreate the view when a go.mod file is created #40340

Open
stamblerre opened this issue Jul 22, 2020 · 1 comment
Open

x/tools/gopls: don't recreate the view when a go.mod file is created #40340

stamblerre opened this issue Jul 22, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 22, 2020

This caused golang/vscode-go#363, because a go.mod was being created during that test, and the completion request was reaching the server at the time that the view was shutting down.

We either need to handle such a situation more gracefully, or we shouldn't shut down a view on go.mod creation. That would mean putting a mutex around a lot of the view's fields that we treat as immutable.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 30, 2020

Change https://golang.org/cl/245818 mentions this issue: internal/lsp: add a test for golang/go#37069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.