Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't recreate the view when a go.mod file is created #40340

Closed
stamblerre opened this issue Jul 22, 2020 · 3 comments
Closed

x/tools/gopls: don't recreate the view when a go.mod file is created #40340

stamblerre opened this issue Jul 22, 2020 · 3 comments
Assignees
@stamblerre
Labels
Tools gopls
Milestone
gopls/v0.5.2

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 22, 2020

This caused golang/vscode-go#363, because a go.mod was being created during that test, and the completion request was reaching the server at the time that the view was shutting down.

We either need to handle such a situation more gracefully, or we shouldn't shut down a view on go.mod creation. That would mean putting a mutex around a lot of the view's fields that we treat as immutable.
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Jul 22, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre mentioned this issue Jul 30, 2020
Closed
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 30, 2020

Change https://golang.org/cl/245818 mentions this issue: internal/lsp: add a test for golang/go#37069
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Aug 10, 2020

This is likely related to the flake seen here: https://storage.googleapis.com/go-build-log/ba9e1088/linux-386_f12e4b30.log.
gopherbot pushed a commit to golang/tools that referenced this issue Sep 1, 2020
@stamblerre
internal/lsp: add a test that reproduces golang/go#37069
fd8950f 
Also, add a directory parameter to RunGoCommand. To make sure that the
parameters aren't misused, change args to a []string.

Updates golang/go#40340

Change-Id: Ib5ce606a401a18c29c904b570ec9339f067a3961
Reviewed-on: https://go-review.googlesource.com/c/tools/+/245818
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2020

Change https://golang.org/cl/260078 mentions this issue: internal/lsp: move the workspaceMode into the snapshot
@stamblerre stamblerre self-assigned this Oct 7, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.2 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stamblerre stamblerre

Labels
Tools gopls
Projects
None yet
Milestone
gopls/v0.5.2
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot