Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Windows service lifecycle events behave incorrectly when called within a golang environment [1.14 backport] #40411

Open
gopherbot opened this issue Jul 26, 2020 · 7 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 26, 2020

@alexbrainman requested issue #40167 to be considered for backport to the next 1.14 minor release.

I think the CL (242280) is safe,

Thank you for checking, @ianlancetaylor

but I don't know how important it is to land at this late stage of the release cycle. I gave the CL a +1 and I'll let Alex decide whether to put it in for 1.15.

I think CL 242280 is important enough so it is available to Go 1.14 and 1.15 users, but is not important enough so it delays imminent Go 1.15 release. So, I propose, we merge CL 242280 on release-branch.go1.14 and release-branch.go1.15 (once Go 1.15 is released) branches. And submit CL 243597 on master once Go 1.15 is released.

@gopherbot, please backport to Go 1.14 and Go 1.15. This is serious problem where Windows service does not receives stop / shutdown event.

@zx2c4 would you, please, copy CL 242280 onto release-branch.go1.14, so we can have it available as soon as possible. Or I can do it myself, if you like.

Thank you.

Alex

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 27, 2020

Change https://golang.org/cl/242280 mentions this issue: [release-branch.go1.14] runtime: detect services in signal handler

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 27, 2020

Change https://golang.org/cl/244957 mentions this issue: [release-branch.go1.14] runtime: detect services in signal handler

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jul 27, 2020

Change https://golang.org/cl/244958 mentions this issue: [release-branch.go1.14] runtime: detect services in signal handler

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Jul 27, 2020

Sorry for the churn. Please consult only https://golang.org/cl/244958

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Aug 1, 2020

@dmitshur sorry to bother you, but we need this to be approved to be backported to go1.14. Can you help with that? If not, do you know who can approve it?

Thank you.

Alex

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 1, 2020

Thanks, we’ll try to take a look at this request next week.

For programs where it’s critical to receive stop / shutdown event, do you know if there is a workaround that can be used until this issue is resolved?

I’ve also asked a question on the upstream issue about 1.13 since that affects the 1.14 backport.

/cc @toothrot @cagedmangis @andybons

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Aug 1, 2020

Thanks, we’ll try to take a look at this request next week.

Sounds good. Thank you.

For programs where it’s critical to receive stop / shutdown event, do you know if there is a workaround that can be used until this issue is resolved?

I don't know a workaround. Maybe others have good suggestions.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.