Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: adjust protocol generator to make command arguments of type []json.RawMessage #40437

Closed
stamblerre opened this issue Jul 27, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 27, 2020

https://golang.org/cl/242697 changed the way that we pass arguments to protocol.Commands, and as part of that, changed the type of protocol.Command.Arguments from []interface{} to []json.RawMessage.

@pjweinbgo, do you mind updating the protocol generator to account for this change?

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 27, 2020
@stamblerre stamblerre added the NeedsFix label Jul 27, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jul 28, 2020

Closed via https://golang.org/cl/245134. Thanks for the quick turnaround on this, @pjweinbgo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.