Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upx/pkgsite: select healthy DB per request #40444
Open
Comments
|
Change https://golang.org/cl/244603 mentions this issue: |
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Jul 28, 2020
Reorganize the server so that each request gets its own DataSource, instead of using a single DataSource for every request. Currently, the behavior doesn't change because we do in fact use the same DataSource for every request. But this paves the way to having a pool of health-checked DB connections, while still having each request work with a single connection. For golang/go#40444. Change-Id: I717450593a8dcfd5689a8d28f634324776305042 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/244603 Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, our service processes connect to a single DB on startup. If that DB enters a bad state while running, the process continues to run, serving 500s.
Instead, we should pick from a set of healthy DBs on each request.