Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: set up govim regression tests to run at govim@main #40451
@heschik has mentioned that, now that we have our own regression tests, it feels like it's time to stop relying on the
When the govim tests fail, we have started rewriting them into our own regression tests, which seems like the right approach. I think the govim tests are a little brittle - particularly because pinning a
It is nice to be able to catch things earlier, so maybe we could have the govim tests running for
You mean 'useless' in the sense that they're already failing? That will still happen if you submit a breaking CL... but I think you mean just that it would be good to keep things more closely in sync. As long as you don't mind getting an email for every failure until things are fixed, I'll set them up to run gopls@master and govim@master.
Yeah exactly. Having them both run at master would be great, so then we can send a PR to govim whenever we make a breaking change.
We're going to switch to running govim tests at main as post-submit CI rather than presubmit, and will also switch to running them via Kokoro using the run_local script rather than cloud build. Enable this by changing the semantics of run_local.sh to default to main. For golang/go#40451 Change-Id: I9c311dea8326a36a3f8335eddbfae0ce7f02f6bf Reviewed-on: https://go-review.googlesource.com/c/tools/+/245539 Run-TryBot: Robert Findley <firstname.lastname@example.org> Reviewed-by: Rebecca Stambler <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org>