Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add a regression test for the upgrade code lens when -mod=readonly is set #40455

Closed
stamblerre opened this issue Jul 28, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 28, 2020

Add a regression test for https://go-review.googlesource.com/c/tools/+/232477.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 28, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to Testing in vscode-go: gopls by default Nov 10, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Dec 15, 2020

This is no longer relevant, as default to -mod=readonly and the upgrade code lenses have been changed.

@stamblerre stamblerre closed this Dec 15, 2020
vscode-go: gopls by default automation moved this from Testing to Done Dec 15, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants