Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: import diagnostic range breaks on dashes #40466

Closed
muirdm opened this issue Jul 29, 2020 · 1 comment
Closed

x/tools/gopls: import diagnostic range breaks on dashes #40466

muirdm opened this issue Jul 29, 2020 · 1 comment
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Jul 29, 2020

Import diagnostics have the wrong range for package paths that contain dashes:

Screen Shot 2020-07-28 at 10 05 02 PM

[Trace - 10:04:54 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
  "diagnostics": [
    {
      "message": "\"github.com/go-playground/locales/en_US\" imported but not used",
      "source": "compiler",
      "severity": 1,
      "range": {
        "end": {
          "character": 21,
          "line": 2
        },
        "start": {
          "character": 7,
          "line": 2
        }
      }
    }
  ],
  "version": 531,
  "uri": "file:///Users/muir/scratch/foo/foo.go"
}
@gopherbot gopherbot added this to the Unreleased milestone Jul 29, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 29, 2020

Thanks for the report! Duplicate of #37936.

@stamblerre stamblerre closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.