Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: improve completion for printf args #40485

Closed
muirdm opened this issue Jul 30, 2020 · 1 comment
Closed

x/tools/gopls: improve completion for printf args #40485

muirdm opened this issue Jul 30, 2020 · 1 comment
Labels
FeatureRequest Tools gopls

Comments

@muirdm
Copy link

@muirdm muirdm commented Jul 30, 2020

It would be cool if gopls could rank completion candidates based on printf verbs:

// prefer ints
fmt.Printf("%d", <>)

We can probably share code with tools/go/analysis/passes/printf/printf.go for most of the hard work.
@gopherbot gopherbot added this to the Unreleased milestone Jul 30, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 30, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

Change https://golang.org/cl/246699 mentions this issue: internal/lsp/source: improve completion of printf operands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest Tools gopls
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@stamblerre @gopherbot @muirdm